KAFKA-7080 and KAFKA-7222: Cleanup overlapping KIP changes#5804
Merged
mjsax merged 3 commits intoapache:trunkfrom Oct 16, 2018
Merged
KAFKA-7080 and KAFKA-7222: Cleanup overlapping KIP changes#5804mjsax merged 3 commits intoapache:trunkfrom
mjsax merged 3 commits intoapache:trunkfrom
Conversation
Member
mjsax
commented
Oct 16, 2018
mjsax
commented
- KIP-319 and KIP-328 overlap and we can remove non-released deprecates methods
- add upgrade docs for KIP-319
Member
Author
|
Call for review @guozhangwang @bbejeck @vvcephei |
bbejeck
approved these changes
Oct 16, 2018
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
LGTM just two very minor comments
mjsax
commented
Oct 16, 2018
Member
Author
There was a problem hiding this comment.
This is part of KIP-358 but slipped in the PR
mjsax
commented
Oct 16, 2018
Member
Author
There was a problem hiding this comment.
added in KIP-319, deprecated in KIP-328
mjsax
commented
Oct 16, 2018
Member
Author
There was a problem hiding this comment.
added in KIP-319, deprecated in KIP-358
mjsax
commented
Oct 16, 2018
Member
Author
There was a problem hiding this comment.
added in KIP-319 -- should have bee deprecated with KIP-328.
guozhangwang
approved these changes
Oct 16, 2018
Contributor
guozhangwang
left a comment
guozhangwang
left a comment
There was a problem hiding this comment.
@mjsax please feel free to merge after rebase.
also: add upgrade docs for KIP-319
mjsax
added a commit
that referenced
this pull request
Oct 16, 2018
Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <guozhang@confluent.io>
Member
Author
|
Merged to |
3 tasks
Contributor
|
I think there is an error in materialize line 198 in org.apache.kafka.streams.kstream.internals.TimeWindowedKstreamImpl. |
Contributor
|
@enothereska There's a follow up already in #5806 that I think addresses your concern |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <guozhang@confluent.io>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
apache#5804 removed `Windows#segmentInterval`, but did not remove all references to it. Author: John Roesler <john@confluent.io> Reviewers: Damian Guy <damian.guy@gmail.com>, Ewen Cheslack-Postava <ewen@confluent.io> Closes apache#5806 from vvcephei/fix-missing-segment-interval
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.