Merged
Conversation
Member
Author
|
Call for review @guozhangwang @bbejeck @vvcephei Need to be cherry-picked to |
Member
Author
|
@bbejeck Pushed two more commits... |
vvcephei
approved these changes
Oct 23, 2018
Contributor
vvcephei
left a comment
vvcephei
left a comment
There was a problem hiding this comment.
Thanks for this! Just one super minor comment.
| <p> | ||
| We deprecated <code>KafkaStreams#close(...)</code> and replaced it with <code>KafkaStreams#close(Duration)</code> that accepts a single timeout argument | ||
| Note: the new <code>#close</code> method has improved (but slightly different) semantics than the old one. | ||
| Note: the new <code>#close(Duration)</code> method has improved (but slightly different) semantics than the old one. |
Contributor
There was a problem hiding this comment.
What do you think about removing "than the old one"? It's redundant to saying that "the new one is improved", and I think (but am not sure) that "improved/than" should be "improved/to". Since it's redundant anyway, taking it out would tighten up the sentence.
mjsax
added a commit
that referenced
this pull request
Oct 23, 2018
Reviewers: Bill Bejeck <bill@confluent.io>, John Roesler <john@confluent.io>
Member
Author
|
Merged to |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Reviewers: Bill Bejeck <bill@confluent.io>, John Roesler <john@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)