MINOR: remove duplicated code in ConsumerPerformance#5828
Merged
ijuma merged 3 commits intoapache:trunkfrom Oct 28, 2018
Merged
MINOR: remove duplicated code in ConsumerPerformance#5828ijuma merged 3 commits intoapache:trunkfrom
ijuma merged 3 commits intoapache:trunkfrom
Conversation
… ConsumerPerformance. In `consume` method, the consumer subscribes the topic as expected, so there is no need to do the same thing ahead of this method call.
Contributor
Author
|
Call for review @ijuma |
…seless_code_consumerperf
Contributor
Author
|
Please review this minor change. @hachikuji |
Member
|
Thanks for the PR. Maybe you can clean-up the following in the - val startMs = System.currentTimeMillis
- var lastReportTime: Long = startMs
- var lastConsumedTime = System.currentTimeMillis
- var currentTimeMillis = lastConsumedTime
+ var currentTimeMillis = System.currentTimeMillis
+ var lastReportTime: Long = currentTimeMillis
+ var lastConsumedTime = currentTimeMillis |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…he#5828) In the `consume` method, the consumer subscribes the topic, so no need to do the same thing before the method call. Also include minor clean-up in `consume`. Reviewers: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
consumemethod, the consumer subscribes the topic as expected, so there is no need to do the same thing ahead of this method call.More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)