KAFKA-7532: Fix controller log for list of shutting down brokers#5831
Merged
ijuma merged 1 commit intoapache:trunkfrom Oct 26, 2018
stanislavkozlovski:KAFKA-7532
Merged
KAFKA-7532: Fix controller log for list of shutting down brokers#5831ijuma merged 1 commit intoapache:trunkfrom stanislavkozlovski:KAFKA-7532
ijuma merged 1 commit intoapache:trunkfrom
stanislavkozlovski:KAFKA-7532
Conversation
Member
|
Retest this please. |
Member
|
Will merge to trunk. This is a cosmetic fix so I don't think we need to backport it. |
ijuma
reviewed
Oct 24, 2018
Member
There was a problem hiding this comment.
We should probably only log this if the list is not empty.
Member
|
If we avoid the log when the seq is empty, then maybe it's worth cherry-picking to 2.1 and 2.0 since it provides more value that way. |
…only log if there are such brokers
ijuma
pushed a commit
that referenced
this pull request
Oct 26, 2018
This line prints out (when empty): ``` [2018-10-23 12:19:59,977] INFO [Controller id=0] Removed ArrayBuffer() from list of shutting down brokers. (kafka.controller.KafkaController) ``` Use `mkString` to eliminate `ArrayBuffer` and only log if not empty. Reviewers: Ismael Juma <ismael@juma.me.uk>
ijuma
pushed a commit
that referenced
this pull request
Oct 26, 2018
This line prints out (when empty): ``` [2018-10-23 12:19:59,977] INFO [Controller id=0] Removed ArrayBuffer() from list of shutting down brokers. (kafka.controller.KafkaController) ``` Use `mkString` to eliminate `ArrayBuffer` and only log if not empty. Reviewers: Ismael Juma <ismael@juma.me.uk>
Member
|
Merged to trunk, 2.1 and 2.0. |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…e#5831) This line prints out (when empty): ``` [2018-10-23 12:19:59,977] INFO [Controller id=0] Removed ArrayBuffer() from list of shutting down brokers. (kafka.controller.KafkaController) ``` Use `mkString` to eliminate `ArrayBuffer` and only log if not empty. Reviewers: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in KAFKA-7532 - this line prints out
This change seems to be present in all versions even as back as
0.9.0. I think it might be worth it to merge to1.0(pre-2.0 uses"".format())