Skip to content

MINOR: KStreams SuppressionIntegrationTest should set StreamsConfig.STATE_CONFIG_DIR.#5847

Merged
ijuma merged 1 commit intoapache:trunkfrom
lbradstreet:suppressionintegration-statedir
Oct 28, 2018
Merged

MINOR: KStreams SuppressionIntegrationTest should set StreamsConfig.STATE_CONFIG_DIR.#5847
ijuma merged 1 commit intoapache:trunkfrom
lbradstreet:suppressionintegration-statedir

Conversation

@lbradstreet
Copy link
Copy Markdown
Contributor

@lbradstreet lbradstreet commented Oct 27, 2018

This sets StreamsConfig.STATE_DIR_CONFIG to temp directory in KStreams SuppressionIntegrationTest, to match StreamsTestUtils.

This is a similar fix to #5826.

Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Oct 28, 2018

JDK8 job passed, JDK 11 had one unrelated failure due to a flaky test that has been just fixed.

@ijuma ijuma merged commit 7cdc433 into apache:trunk Oct 28, 2018
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Oct 28, 2018

Merged to trunk.

@lbradstreet lbradstreet deleted the suppressionintegration-statedir branch May 7, 2019 02:05
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
…CONFIG (apache#5847)

Sets StreamsConfig.STATED_DIR_CONFIG to temp directory in
SuppressionIntegrationTest, to match StreamsTestUtils.

This is a similar fix to apache#5826.

Reviewers: Ismael Juma <ismael@juma.me.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants