KAFKA-7509: Logging unused configs as DEBUG rather than WARN#5867
Closed
rhauch wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-7509: Logging unused configs as DEBUG rather than WARN#5867rhauch wants to merge 1 commit intoapache:trunkfrom
rhauch wants to merge 1 commit intoapache:trunkfrom
Conversation
The KafkaProducer, KafkaConsumer, and KafkaAdminClient all call `config.logUnused()` to log all of the unused configurations. These can be very misleading, because some conventional configuration properties for custom interceptors, key or value (de)serializers, metrics reporters, and partitioner are not actually defined by ConfigDefs and are thus all considered unused and logged as warnings. Also, some client applications (such as Connect) do not determine the subset of properties that can be passed to one of these clients, since there are these custom extensions. This causes extra properties to be logged as warnings, which is concerning for new users. These unused configurations should be logged at DEBUG level instead to reduce the number of unexpected warnings in many client application logs.
3 tasks
Contributor
Author
|
Supersedes #5802 |
Contributor
Author
|
retest this please |
3 tasks
Contributor
Author
|
See KAFKA-7509 for discussion. This approach is to invasive, since it is beneficial for clients to log unused messages in custom applications. Closing this without merging, and instead favoring #5876 that simply filters the properties before passing them to the clients. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The KafkaProducer, KafkaConsumer, and KafkaAdminClient all call
config.logUnused()to log all of the unused configurations. These can be very misleading, because some conventional configuration properties for custom interceptors, key or value (de)serializers, metrics reporters, and partitioner are not actually defined by ConfigDefs and are thus all considered unused and logged as warnings.Also, some client applications (such as Connect) do not determine the subset of properties that can be passed to one of these clients, since there are these custom extensions. This causes extra properties to be logged as warnings, which is concerning for new users.
These unused configurations should be logged at DEBUG level instead to reduce the number of unexpected warnings in many client application logs.
Backporting
This is a usability improvement that affects only this particular log message. As such, it may or may not be something that should be backported. Advice from committers would be appreciated.
Committer Checklist (excluded from commit message)