Skip to content

MINOR: Code cleanup in StreamsResetter#5891

Merged
guozhangwang merged 1 commit intoapache:trunkfrom
mjsax:minor-streamresetter-cleanup
Nov 15, 2018
Merged

MINOR: Code cleanup in StreamsResetter#5891
guozhangwang merged 1 commit intoapache:trunkfrom
mjsax:minor-streamresetter-cleanup

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Nov 8, 2018

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Nov 8, 2018

Call for review @guozhangwang @bbejeck @vvcephei

Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mjsax LGTM

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Nov 8, 2018

retest this please

Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the separate code-cleanup PR.

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Nov 8, 2018

Java11: https://builds.apache.org/job/kafka-pr-jdk11-scala2.12/535/

Test Result (14 failures / -1)

kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsNotExistingGroup
kafka.api.CustomQuotaCallbackTest.testCustomQuotaCallback
kafka.api.PlaintextConsumerTest.testLowMaxFetchSizeForRequestAndPartition
kafka.api.SaslMultiMechanismConsumerTest.testCoordinatorFailover
kafka.api.SaslPlainPlaintextConsumerTest.testCoordinatorFailover
kafka.api.SaslSslAdminClientIntegrationTest.testAclDescribe
kafka.api.SaslSslAdminClientIntegrationTest.testLegacyAclOpsNeverAffectOrReturnPrefixed
kafka.api.SaslSslConsumerTest.testCoordinatorFailover
kafka.api.SslConsumerTest.testCoordinatorFailover
kafka.tools.MirrorMakerIntegrationTest.testCommaSeparatedRegex
org.apache.kafka.streams.integration.RepartitionWithMergeOptimizingIntegrationTest.shouldSendCorrectRecords_OPTIMIZED
org.apache.kafka.streams.integration.ResetIntegrationTest.shouldNotAllowToResetWhenInputTopicAbsent
org.apache.kafka.streams.integration.ResetIntegrationWithSslTest.testReprocessingFromScratchAfterResetWithIntermediateUserTopic
org.apache.kafka.streams.integration.SuppressionIntegrationTest.shouldSuppressIntermediateEventsWithRecordLimit

Java8:

kafka.api.PlaintextConsumerTest.testCoordinatorFailover
kafka.api.SslConsumerTest.testCoordinatorFailover

Retest this please

@guozhangwang guozhangwang merged commit 9346660 into apache:trunk Nov 15, 2018
@mjsax mjsax deleted the minor-streamresetter-cleanup branch November 17, 2018 03:21
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Reviewers: Bill Bejeck <bill@confluent.io>, John Roesler <john@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants