Skip to content

MINOR: improve Puncutation JavaDocs and add runtime argument check#5895

Merged
guozhangwang merged 1 commit intoapache:trunkfrom
mjsax:minor-improve-punctuation
Nov 15, 2018
Merged

MINOR: improve Puncutation JavaDocs and add runtime argument check#5895
guozhangwang merged 1 commit intoapache:trunkfrom
mjsax:minor-improve-punctuation

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Nov 8, 2018

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@mjsax mjsax added the streams label Nov 8, 2018
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Nov 8, 2018

Call for review @guozhangwang @bbejeck @vvcephei

Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for changes @mjsax LGTM

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Nov 8, 2018

Java11: https://builds.apache.org/job/kafka-pr-jdk11-scala2.12/545/#showFailuresLink

Test Result (10 failures / -2)

org.apache.kafka.connect.runtime.WorkerTest.testCleanupTasksOnStop
kafka.api.PlaintextConsumerTest.testCoordinatorFailover
kafka.api.SaslPlainPlaintextConsumerTest.testCoordinatorFailover
org.apache.kafka.streams.processor.internals.StateDirectoryTest.shouldCleanUpTaskStateDirectoriesThatAreNotCurrentlyLocked
kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsNotExistingGroup
kafka.api.PlaintextConsumerTest.testLowMaxFetchSizeForRequestAndPartition
org.apache.kafka.streams.integration.ResetIntegrationWithSslTest.testReprocessingFromScratchAfterResetWithIntermediateUserTopic
org.apache.kafka.streams.integration.SuppressionIntegrationTest.shouldSuppressIntermediateEventsWithRecordLimit
kafka.api.CustomQuotaCallbackTest.testCustomQuotaCallback
kafka.tools.MirrorMakerIntegrationTest.testCommaSeparatedRegex

Java8: kafka.api.SaslMultiMechanismConsumerTest.testCoordinatorFailover

Retest this please.

@guozhangwang guozhangwang merged commit 80eb2c2 into apache:trunk Nov 15, 2018
@mjsax mjsax deleted the minor-improve-punctuation branch November 17, 2018 03:21
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
…pache#5895)

Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants