Skip to content

MINOR: Remove unused IteratorTemplate#5903

Merged
ijuma merged 1 commit intoapache:trunkfrom
hachikuji:remove-unused-iterator-template
Nov 12, 2018
Merged

MINOR: Remove unused IteratorTemplate#5903
ijuma merged 1 commit intoapache:trunkfrom
hachikuji:remove-unused-iterator-template

Conversation

@hachikuji
Copy link
Copy Markdown
Contributor

There seems to be no reason to keep this around since it is not used outside of testing and AbstractIterator is basically the same thing.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@hachikuji hachikuji requested a review from omkreddy November 12, 2018 06:58
Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Nov 12, 2018

retest this please

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Nov 12, 2018

All failures were testCoordinatorFailure which is being addressed in a separate PR.

@ijuma ijuma merged commit 6c2e700 into apache:trunk Nov 12, 2018
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
There seems to be no reason to keep this around since it is not used outside
of testing and AbstractIterator is basically the same thing.

Reviewers: Ismael Juma <ismael@juma.me.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants