KAFKA-7633: Allow Kafka Connect to access internal topics without cluster ACLs#5918
Merged
hachikuji merged 1 commit intoapache:trunkfrom May 11, 2019
Merged
KAFKA-7633: Allow Kafka Connect to access internal topics without cluster ACLs#5918hachikuji merged 1 commit intoapache:trunkfrom
hachikuji merged 1 commit intoapache:trunkfrom
Conversation
…ster ACLs When Kafka Connect does not have cluster ACLs to create topics, it fails to even access its internal topics which already exist. This was originally fixed in KAFKA-6250 by ignoring the cluster authorization error, but now Kafka 2.0 returns a different response code that corresponds to a different error. Add a patch to ignore this new error as well.
arabelle
changed the title
Contributor
Author
|
Hey @hachikuji, sorry I'm a bit new to this but since you reviewed a similar pull request to this, do you mind taking a look at this as well? |
Contributor
Author
|
retest this please |
|
FWIW I encountered exactly the same issue today. |
hachikuji
approved these changes
May 11, 2019
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Apologies for the delay. This is a good find. LGTM.
Contributor
|
retest this please |
hachikuji
pushed a commit
that referenced
this pull request
May 11, 2019
…ster ACLs (#5918) When Kafka Connect does not have cluster ACLs to create topics, it fails to even access its internal topics which already exist. This was originally fixed in KAFKA-6250 by ignoring the cluster authorization error, but now Kafka 2.0 returns a different response code that corresponds to a different error. Add a patch to ignore this new error as well. Reviewers: Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
May 11, 2019
…ster ACLs (#5918) When Kafka Connect does not have cluster ACLs to create topics, it fails to even access its internal topics which already exist. This was originally fixed in KAFKA-6250 by ignoring the cluster authorization error, but now Kafka 2.0 returns a different response code that corresponds to a different error. Add a patch to ignore this new error as well. Reviewers: Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
May 11, 2019
…ster ACLs (#5918) When Kafka Connect does not have cluster ACLs to create topics, it fails to even access its internal topics which already exist. This was originally fixed in KAFKA-6250 by ignoring the cluster authorization error, but now Kafka 2.0 returns a different response code that corresponds to a different error. Add a patch to ignore this new error as well. Reviewers: Jason Gustafson <jason@confluent.io>
omkreddy
added a commit
to confluentinc/kafka
that referenced
this pull request
May 13, 2019
…es-14-May * AK_REPO/trunk: (24 commits) KAFKA-7321: Add a Maximum Log Compaction Lag (KIP-354) (apache#6009) KAFKA-8335; Clean empty batches when sequence numbers are reused (apache#6715) KAFKA-6455: Session Aggregation should use window-end-time as record timestamp (apache#6645) KAFKA-6521: Use timestamped stores for KTables (apache#6667) [MINOR] Consolidate in-memory/rocksdb unit tests for window & session store (apache#6677) MINOR: Include StickyAssignor in system tests (apache#5223) KAFKA-7633: Allow Kafka Connect to access internal topics without cluster ACLs (apache#5918) MINOR: Align KTableAgg and KTableReduce (apache#6712) MINOR: Fix code section formatting in TROGDOR.md (apache#6720) MINOR: Remove unnecessary OptionParser#accepts method call from PreferredReplicaLeaderElectionCommand (apache#6710) KAFKA-8352 : Fix Connect System test failure 404 Not Found (apache#6713) KAFKA-8348: Fix KafkaStreams JavaDocs (apache#6707) MINOR: Add missing option for running vagrant-up.sh with AWS to vagrant/README.md KAFKA-8344; Fix vagrant-up.sh to work with AWS properly MINOR: docs typo in '--zookeeper myhost:2181--execute' MINOR: Remove header and key/value converter config value logging (apache#6660) KAFKA-8231: Expansion of ConnectClusterState interface (apache#6584) KAFKA-8324: Add close() method to RocksDBConfigSetter (apache#6697) KAFKA-6789; Handle retriable group errors in AdminClient API (apache#5578) KAFKA-8332: Refactor ImplicitLinkedHashSet to avoid losing ordering when converting to Scala ...
|
Which version (https://hub.docker.com/r/confluentinc/cp-kafka-connect/tags) of Kafka Connect docker image would have this fix ? If not, how do we get this fix pushed to docker hub as well ? |
Contributor
|
@muzeebullah This was merged recently, so I don't think any of the tags have it yet. That said, it made it in time for AK 2.2.1, so I'd expect a corresponding tag to appear very soon. |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…ster ACLs (apache#5918) When Kafka Connect does not have cluster ACLs to create topics, it fails to even access its internal topics which already exist. This was originally fixed in KAFKA-6250 by ignoring the cluster authorization error, but now Kafka 2.0 returns a different response code that corresponds to a different error. Add a patch to ignore this new error as well. Reviewers: Jason Gustafson <jason@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Kafka Connect does not have cluster ACLs to create topics,
it fails to even access its internal topics which already exist.
This was originally fixed in https://issues.apache.org/jira/browse/KAFKA-6250 #4247 by ignoring the cluster authorization error, but now Kafka 2.0 returns a different response
code that corresponds to a different error. Add a patch to ignore this
new error as well.
Committer Checklist (excluded from commit message)