KAFKA-6567: Remove KStreamWindowReducer#5922
Merged
guozhangwang merged 4 commits intoapache:trunkfrom Nov 20, 2018
Merged
Conversation
Signed-off-by: Samuel Hawker <samuel.hawker@ibm.com>
samuel-hawker
changed the title
samuel-hawker
changed the title
Signed-off-by: Samuel Hawker <samuel.hawker@ibm.com>
mjsax
reviewed
Nov 19, 2018
| Objects.requireNonNull(materialized, "materialized can't be null"); | ||
|
|
||
| final MaterializedInternal<K, V, WindowStore<Bytes, byte[]>> materializedInternal = new MaterializedInternal<>(materialized); | ||
| final Aggregator<K, V, V> reduceAggregator = aggregatorForReducer(reducer); |
Member
There was a problem hiding this comment.
Nit: I would inline this method. It's a single liner and only used once.
Contributor
Author
There was a problem hiding this comment.
I have inlined it, good catch.
Signed-off-by: Samuel Hawker <sam.b.hawker@gmail.com>
Contributor
Author
|
The build failed, not sure why, they worked locally and I only moved the function call inline |
Contributor
Author
|
retest this please |
Member
|
Thanks for the PR @samuel-hawker and congrats to your first contribution to Kafka! 🎉 |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
This pull request removes the final reference to KStreamWindowReducer and replaces it with KStreamWindowAggregate Signed-off-by: Samuel Hawker sam.b.hawker@gmail.com contribution is my original work and that I license the work to the project under the project's open source license. Reviewers: Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes the final reference to
KStreamWindowReducerand replaces it withKStreamWindowAggregateSigned-off-by: Samuel Hawker sam.b.hawker@gmail.com
contribution is my original work and that I license the work to the project under the project's open source license.
Committer Checklist (excluded from commit message)