KAFKA-7536: Initialize TopologyTestDriver with non-null topic#5923
Merged
guozhangwang merged 4 commits intoapache:trunkfrom Nov 20, 2018
Merged
KAFKA-7536: Initialize TopologyTestDriver with non-null topic#5923guozhangwang merged 4 commits intoapache:trunkfrom
guozhangwang merged 4 commits intoapache:trunkfrom
Conversation
mjsax
reviewed
Nov 18, 2018
| ); | ||
| globalStateTask.initialize(); | ||
| globalProcessorContext.setRecordContext(new ProcessorRecordContext(0L, -1L, -1, null, new RecordHeaders())); | ||
| globalProcessorContext.setRecordContext(new ProcessorRecordContext(0, -1L, -1, ProcessorContextImpl.NONEXIST_TOPIC, new RecordHeaders())); |
Member
There was a problem hiding this comment.
Nit: why change 0L to 0 ? Timestamp is of type long. (sam below)
| Stores.inMemoryKeyValueStore("aggStore"), | ||
| Serdes.String(), | ||
| Serdes.Long()), | ||
| Serdes.Long()).withCachingEnabled(), // intentionally turn on caching to achieve better test coverage |
Member
There was a problem hiding this comment.
I would prefer a separate test: shouldAllowPrePopulatingStatesStoresWithCachingEnabled()
Contributor
Author
|
@mjsax addressed comments. |
bbejeck
approved these changes
Nov 19, 2018
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Thanks for this @guozhangwang. LGTM
Member
|
failures unrelated restest this please |
mjsax
approved these changes
Nov 20, 2018
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
One nit.
LGTM. Feel free to merge.
Test timed out. Retest this please.
| topology.addStateStore(Stores.keyValueStoreBuilder( | ||
| Stores.inMemoryKeyValueStore("aggStore"), | ||
| Serdes.String(), | ||
| Serdes.Long()).withCachingEnabled(), // intentionally turn on caching to achieve better test coverage |
Member
There was a problem hiding this comment.
nit: we can remove this comment, as the test name explains it :)
guozhangwang
added a commit
that referenced
this pull request
Nov 20, 2018
In TopologyTestDriver constructor set non-null topic; and in unit test intentionally turn on caching to verify this case. Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
guozhangwang
added a commit
that referenced
this pull request
Nov 20, 2018
In TopologyTestDriver constructor set non-null topic; and in unit test intentionally turn on caching to verify this case. Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
Contributor
Author
|
I tried to cherry-pick to the earliest branch (1.1) but realized it has a few other diffs like KAFKA-6967 in the middle which are not cherry-picked either and hence making the divergence too large. Instead I'd only cherry-pick to 2.0 and 2.1. |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…#5923) In TopologyTestDriver constructor set non-null topic; and in unit test intentionally turn on caching to verify this case. Reviewers: Bill Bejeck <bill@confluent.io>, Matthias J. Sax <matthias@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In TopologyTestDriver constructor set non-null topic; and in unit test intentionally turn on caching to verify this case.
Committer Checklist (excluded from commit message)