MINOR: Update docs with out-dated context.schedule(...) examples#5924
Merged
mjsax merged 1 commit intoapache:trunkfrom Nov 21, 2018
Merged
MINOR: Update docs with out-dated context.schedule(...) examples#5924mjsax merged 1 commit intoapache:trunkfrom
mjsax merged 1 commit intoapache:trunkfrom
Conversation
This commit updates the first parameter of example calls to context.schedule(...) in documentations from time durations in milliseconds of type long to time durations expressed as class java.time.Duration.
3 tasks
mjsax
approved these changes
Nov 20, 2018
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
LGTM.
Call for second review. Anyof @guozhangwang @bbejeck @vvcephei
We should cherry-pick this into 2.1, too.
mjsax
pushed a commit
that referenced
this pull request
Nov 21, 2018
Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>
Member
|
Merged to |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…che#5924) Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the first parameter of example calls to
context.schedule(...) in documentations from time durations in
milliseconds of type long to time durations expressed as class
java.time.Duration.
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)