Skip to content

MINOR: fix failing Streams system tests#5928

Merged
mjsax merged 1 commit intoapache:trunkfrom
mjsax:fix-system-tests-220
Nov 20, 2018
Merged

MINOR: fix failing Streams system tests#5928
mjsax merged 1 commit intoapache:trunkfrom
mjsax:fix-system-tests-220

Conversation

@mjsax
Copy link
Copy Markdown
Member

@mjsax mjsax commented Nov 19, 2018

In #5850 the output that prints the current Kafka version was reformatted (space before : was removed):

Old format:

Kafka version : 2.2.0-SNAPSHOT

New format:

Kafka version: 2.2.0-SNAPSHOT

This breaks some Streams system tests that grep the logs for this line.

@mjsax mjsax added the streams label Nov 19, 2018
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Nov 19, 2018

@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Nov 19, 2018

StreamsBrokerBounceTest system test failed -- seems to be unrelated to this fix though. All StreamsUpgradeTest passed. Are you ok if I merge this and we tackle the failing test separately?

Also EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState failed:

java.lang.AssertionError: 
Expected: <[KeyValue(0, 0), KeyValue(0, 1), KeyValue(0, 3), KeyValue(0, 6), KeyValue(0, 10), KeyValue(0, 15), KeyValue(0, 21), KeyValue(0, 28), KeyValue(0, 36), KeyValue(0, 45)]>
     but: was <[KeyValue(0, 0), KeyValue(0, 1), KeyValue(0, 3), KeyValue(0, 6), KeyValue(0, 10), KeyValue(0, 15), KeyValue(0, 21), KeyValue(0, 28), KeyValue(0, 36), KeyValue(0, 45), KeyValue(0, 55), KeyValue(0, 66), KeyValue(0, 78), KeyValue(0, 91), KeyValue(0, 105)]>
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:8)
	at org.apache.kafka.streams.integration.EosIntegrationTest.checkResultPerKey(EosIntegrationTest.java:218)
	at org.apache.kafka.streams.integration.EosIntegrationTest.shouldNotViolateEosIfOneTaskFailsWithState(EosIntegrationTest.java:438)

Have seen this once in a while lately -- we should investigate.

Other Jenkins test failures seems to be unrelated.

Retest this please.

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Nov 19, 2018

StreamsBrokerBounceTest system test failed -- seems to be unrelated to this fix though. All StreamsUpgradeTest passed. Are you ok if I merge this and we tackle the failing test separately?

Fine with me

Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Nov 19, 2018

@mjsax as side note this PR will help me as I'm working on another system test for broker upgrades and experienced the same failures

@mjsax mjsax merged commit 190cbd9 into apache:trunk Nov 20, 2018
@mjsax
Copy link
Copy Markdown
Member Author

mjsax commented Nov 20, 2018

@bbejeck Merge to trunk. You can rebase your PR to pick up the fix.

@mjsax mjsax deleted the fix-system-tests-220 branch November 20, 2018 02:45
@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Nov 20, 2018

Thanks @mjsax!

pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Reviewers: Guozhang Wang <guozhang@confluent.io>, Bill Bejeck <bill@confluent.io>, John Roesler <john@confluent.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants