KAFKA-7446: Fix the duration and instant validation messages#5930
Merged
guozhangwang merged 1 commit intoapache:trunkfrom Dec 4, 2018
mrsrinivas:KAFKA-7446
Merged
KAFKA-7446: Fix the duration and instant validation messages#5930guozhangwang merged 1 commit intoapache:trunkfrom mrsrinivas:KAFKA-7446
guozhangwang merged 1 commit intoapache:trunkfrom
mrsrinivas:KAFKA-7446
Conversation
mrsrinivas
changed the title
WindowDuration and AdvanceInterval
mrsrinivas
changed the title
mjsax
reviewed
Nov 19, 2018
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for the PR. Couple of comments.
Note: build failed with checkstyle error; please fix.
mrsrinivas
changed the title
Contributor
Author
|
ping @jaceklaskowski @guozhangwang. any thoughts about the changes? TIA |
mjsax
reviewed
Nov 20, 2018
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for updating the PR. Couple of follow ups.
mrsrinivas
changed the title
mrsrinivas
changed the title
mrsrinivas
changed the title
Contributor
Author
mrsrinivas
changed the title
duration and instant validation messages
mrsrinivas
changed the title
duration and instant validation messages
Contributor
Author
|
retest this please |
mrsrinivas
changed the title
mjsax
reviewed
Nov 27, 2018
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Thanks for the update. Some follow up nits.
Contributor
Author
|
@mjsax, Thank you for the review comments. I addressed all the comments. |
mjsax
approved these changes
Nov 28, 2018
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
LGTM.
Call for second review @jaceklaskowski @guozhangwang @bbejeck @vvcephei
bbejeck
approved these changes
Nov 28, 2018
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
Just one minor nit otherwise LGTM.
I have one thought for a follow-on PR, we could consider moving the prepareMillisCheckFailMsgPrefix inside the validateXXX methods and create the formatted string at that point saving the users a method call.
But I think this PR is good enough as is.
Changes made as part of this commit. - Improved error message for better readability at millis validation utility - Corrected java documentation on `AdvanceInterval` check. - Added caller specific prefix text to make error message more clear to developers/users.
Contributor
Author
Contributor
Author
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…#5930) Changes made as part of this commit. - Improved error message for better readability at millis validation utility - Corrected java documentation on `AdvanceInterval` check. - Added caller specific prefix text to make error message more clear to developers/users. Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>, Jacek Laskowski <jacek@japila.pl>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes made as part of this PR for KAFKA-7446
AdvanceIntervalcheck.Core and Streams modules' JUnit tests are successful in local but
tests related to file system is failed since I am running on Windows.
Committer Checklist (excluded from commit message)