MINOR: Support long maxMessages in Trogdor consume/produce bench workers#5957
Merged
cmccabe merged 1 commit intoapache:trunkfrom Nov 28, 2018
stanislavkozlovski:minor-trogdo-long-max-messages
Merged
MINOR: Support long maxMessages in Trogdor consume/produce bench workers#5957cmccabe merged 1 commit intoapache:trunkfrom stanislavkozlovski:minor-trogdo-long-max-messages
cmccabe merged 1 commit intoapache:trunkfrom
stanislavkozlovski:minor-trogdo-long-max-messages
Conversation
Contributor
|
LGTM |
Contributor
|
Failed test is not related to Trogdor |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…ers (apache#5957) Reivewers: Colin McCabe <cmccabe@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes we might want to run intense longer-running benchmarks with Trogdor. We are currently limited to
2147483647. If we use 100 bytes per message, this limits us to 2.4MB/s of throughput a day. (((2147483647 * 100) / 1000000 / 86400))We might want to have longer running tasks than a single day as well, so I think it makes sense to bump this to a long.
cc @cmccabe