MINOR: avoid miss-leading log statement for KafkaStreams#close()#5963
Merged
mjsax merged 1 commit intoapache:2.1from Nov 30, 2018
Merged
MINOR: avoid miss-leading log statement for KafkaStreams#close()#5963mjsax merged 1 commit intoapache:2.1from
mjsax merged 1 commit intoapache:2.1from
Conversation
Member
Author
|
Call for review @guozhangwang @bbejeck @vvcephei @ijuma This fix is also contained in #5954 for |
mjsax
commented
Nov 28, 2018
| */ | ||
| public void close() { | ||
| close(DEFAULT_CLOSE_TIMEOUT, TimeUnit.SECONDS); | ||
| close(Long.MAX_VALUE); |
Member
Author
There was a problem hiding this comment.
We translate old default of zero to Long.MAX_VALUE within deprecated close(final long timeout, final TimeUnit timeUnit) -- we can call private close() directly instead.
guozhangwang
approved these changes
Nov 29, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
KafkaStream#close()should not call deprecated#close()because this will log miss leading log statement about using a deprecated method.