Skip to content

MINOR: Bump Gradle version to 5.0#5964

Merged
ijuma merged 4 commits intoapache:trunkfrom
colinhicks:gradle-5
Nov 30, 2018
Merged

MINOR: Bump Gradle version to 5.0#5964
ijuma merged 4 commits intoapache:trunkfrom
colinhicks:gradle-5

Conversation

@colinhicks
Copy link
Copy Markdown
Contributor

@colinhicks colinhicks commented Nov 29, 2018

Gradle 5.0 was released on 26 November. See the release notes for enhancements and fixes: https://docs.gradle.org/5.0/release-notes.html.

A notable bugfix ensures that Javadoc artifacts are cleaned between builds.

The upgraded wrapper was spot-checked against the commands in the README and the
README was updated not to use removed system property -Dtest.single.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@ijuma ijuma changed the title MINOR: Bump Gradle version to 5.0. MINOR: Bump Gradle version to 5.0 Nov 29, 2018
@ijuma
Copy link
Copy Markdown
Member

ijuma commented Nov 29, 2018

@colinhicks Thanks for the PR. I pushed a couple of additional commits. Let me know what you think.

@colinhicks
Copy link
Copy Markdown
Contributor Author

@ijuma Thanks for the review and edits. I should have noticed that the deprecated single test commands actually cause all the tests to run. I verified that your edits work as documented.

In taking a pass at the commands using Java 11, I noticed that ./gradlew aggregatedJavadoc fails against Java 11, yet succeeds using Java 8. However this does not appear related to the Gradle update, as I see the same behavior against trunk (fails in 11; succeeds in 8). Would you advise filing a separate bug?

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Nov 29, 2018

I had filed a JIRA about the aggregatedJavadoc thing but I think someone closed it. It may be worth reopening.

@ijuma
Copy link
Copy Markdown
Member

ijuma commented Nov 29, 2018

Using from breaks bootstrapping with older Gradle versions so we should remove that commit for now.

@ijuma ijuma merged commit 4a0fd4c into apache:trunk Nov 30, 2018
@colinhicks colinhicks deleted the gradle-5 branch November 30, 2018 00:30
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Gradle 5.0 was released on 26 November. See the release notes for enhancements and fixes: https://docs.gradle.org/5.0/release-notes.html.

A notable bugfix ensures that Javadoc artifacts are cleaned between builds.

The upgraded wrapper was spot-checked against the commands in the README and the
README was updated not to use removed system property `-Dtest.single`.

Reviewers: Ismael Juma <ismael@juma.me.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants