MINOR: Specify character encoding in NetworkTestUtils#5965
Merged
ijuma merged 1 commit intoapache:trunkfrom Dec 8, 2018
Merged
MINOR: Specify character encoding in NetworkTestUtils#5965ijuma merged 1 commit intoapache:trunkfrom
ijuma merged 1 commit intoapache:trunkfrom
Conversation
ijuma
changed the title
ijuma
changed the title
ijuma
changed the title
Member
|
retest this please |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
This attempts to address the flaky test `SaslAuthenticatorTest.testCannotReauthenticateWithDifferentPrincipal()` I was not able to reproduce locally even after 150 test runs in a loop, but given the error message: ``` org.junit.ComparisonFailure: expected: <[6QBJiMZ6o5AqbNAjDTDjWtQSa4alfuUWsYKIy2tt7dz5heDaWZlz21yr8Gl4uEJkQABQXeEL0UebdpufDb5k8SvReSK6wYwQ9huP-9]> but was:<[????����????OAUTHBEARER]> ``` `????����????` seems to mean invalid UTF-8. We now specify the charset when writing out and reading in bytes. Reviewers: Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This attempts to address the flaky test
SaslAuthenticatorTest.testCannotReauthenticateWithDifferentPrincipal()I was not able to reproduce locally even after 150 test runs in a loop, but given the error message:
????����????seems to mean invalid UTF-8.This patch ensures that we specify a charset when writing out and reading in bytes. I'm not sure this fixes the problem but it seems likely.
Committer Checklist (excluded from commit message)