KAFKA-7455: Support JmxTool to connect to a secured RMI port.#5968
Merged
omkreddy merged 3 commits intoapache:trunkfrom May 6, 2019
Merged
KAFKA-7455: Support JmxTool to connect to a secured RMI port.#5968omkreddy merged 3 commits intoapache:trunkfrom
omkreddy merged 3 commits intoapache:trunkfrom
Conversation
asasvari
reviewed
Jan 11, 2019
| // password authentication enable | ||
| if (enablePasswordAuth) { | ||
| val userPassword = options.valueOf(jmxAuthPropOpt).split("=", 2) | ||
| val credentials = Array(userPassword(0), userPassword(1)) |
Contributor
There was a problem hiding this comment.
userPassword is not needed, you can have something like
val credentials = options.valueOf(jmxAuthPropOpt).split("=", 2)
Contributor
Author
|
@omkreddy PTAL, thanks! |
Contributor
|
This may require a minor KIP. |
Member
|
Yes, that's correct. |
Contributor
Author
|
@omkreddy Are there any plans to have this pull request being merged soon? |
Contributor
Author
|
retest this please |
Contributor
Author
Contributor
|
@murong00 Thanks for the PR. LGTM. Can you bump up the KIP-417 vote thread? We need one more binding vote to pass the KIP. |
Contributor
Author
|
@omkreddy Binding vote via this thread, but I'm not sure whether it works. |
Contributor
|
retest this please |
Contributor
|
@murong00 Sorry for the delay. Merging to trunk. |
ijuma
added a commit
to ijuma/kafka
that referenced
this pull request
May 8, 2019
…s-hashcode * apache-github/trunk: KAFKA-8158: Add EntityType for Kafka RPC fields (apache#6503) MINOR: correctly parse version OffsetCommitResponse version < 3 KAFKA-8284: enable static membership on KStream (apache#6673) KAFKA-8304: Fix registration of Connect REST extensions (apache#6651) KAFKA-8275; Take throttling into account when choosing least loaded node (apache#6619) KAFKA-3522: Interactive Queries must return timestamped stores (apache#6661) MINOR: MetricsIntegrationTest should set StreamsConfig.STATE_DIR_CONFIG (apache#6687) MINOR: Remove unused field in `ListenerConnectionQuota` KAFKA-8131; Move --version implementation into CommandLineUtils (apache#6481) KAFKA-8056; Use automatic RPC generation for FindCoordinator (apache#6408) MINOR: Remove workarounds for lz4-java bug affecting byte buffers (apache#6679) KAFKA-7455: Support JmxTool to connect to a secured RMI port. (apache#5968) MINOR: Document improvement (apache#6682) MINOR: Fix ThrottledReplicaListValidator doc error. (apache#6537) KAFKA-8306; Initialize log end offset accurately when start offset is non-zero (apache#6652)
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…#5968) Reviewers: Attila Sasvari <asasvari@apache.org>, Manikumar Reddy <manikumar.reddy@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To connect to a secured RMI port (enabling remote JMX with password authentication and SSL), JmxTool should pass an envionrment map that contains relevant certification entry.