KAFKA-7687: Print batch level information in DumpLogSegments#5976
KAFKA-7687: Print batch level information in DumpLogSegments#5976hachikuji merged 5 commits intoapache:trunkfrom
Conversation
There was a problem hiding this comment.
I think there's some redundant information that we can exclude if we are printing the batch info: position, timestamp type, magic version, compression codec. Below we can also exclude the producerId, epoch, and the transactional flag.
Also, what do you think about using | instead of -?
hachikuji
left a comment
There was a problem hiding this comment.
Thanks for the updates. Just two more comments.
There was a problem hiding this comment.
The old format still has individual record level checksums. I think it would make sense to add back " isvalid: " + record.isValid here.
There was a problem hiding this comment.
On second thought, the timestamp is a per-record field, so can we add batch.timestampType + ": " + record.timestamp back to this string?
…p iterating DumpLogSegment should be able to print batch level information when deep-iteration is specified
|
@hachikuji That's fine to me. Looks it's a more reasonable change. |
…p iterating (apache#5976) DumpLogSegments should print batch level information when deep-iteration is specified. Reviewers: Jason Gustafson <jason@confluent.io>
DumpLogSegment should be able to print batch level information when deep-iteration is specified
More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.
Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.
Committer Checklist (excluded from commit message)