MINOR: improve QueryableStateIntegrationTest#5987
Merged
guozhangwang merged 1 commit intoapache:trunkfrom Dec 3, 2018
Merged
Conversation
mjsax
commented
Dec 2, 2018
| } | ||
| }; | ||
| stringComparator = Comparator.comparing((KeyValue<String, String> o) -> o.key).thenComparing(o -> o.value); | ||
| stringLongComparator = Comparator.comparing((KeyValue<String, Long> o) -> o.key).thenComparingLong(o -> o.value); |
Member
Author
|
Call for review @guozhangwang @bbejeck @vvcephei This should be cherry-picked into |
Contributor
|
Build timed out. Local run passed. |
guozhangwang
approved these changes
Dec 3, 2018
guozhangwang
pushed a commit
that referenced
this pull request
Dec 3, 2018
Fix test Comparators plus Java8 cleanup Reviewers: Guozhang Wang <wangguoz@gmail.com>
guozhangwang
added a commit
that referenced
this pull request
Dec 3, 2018
Contributor
|
Cherry-picked to 2.1 and 2.0 (2.0 has lots of conflicts, so I just pushed the one-liner of the actual fix). |
Member
Author
Cool. That's good enough. Thank you! |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Fix test Comparators plus Java8 cleanup Reviewers: Guozhang Wang <wangguoz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix test
Comparatorsplus Java8 cleanup