KAFKA-7678: Avoid NPE when closing the RecordCollector#5993
Merged
mjsax merged 2 commits intoapache:trunkfrom Dec 5, 2018
Merged
KAFKA-7678: Avoid NPE when closing the RecordCollector#5993mjsax merged 2 commits intoapache:trunkfrom
mjsax merged 2 commits intoapache:trunkfrom
Conversation
jonathansantilli
changed the title
mjsax
reviewed
Dec 4, 2018
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
Overall LGTM. One nit.
Call for second review anyof @guozhangwang @bbejeck @vvcephei
jonathansantilli
force-pushed
the
KAFKA-7678
branch
from
67592e4 to
0fb1553
Compare
Contributor
Author
bbejeck
approved these changes
Dec 4, 2018
Member
bbejeck
left a comment
bbejeck
left a comment
There was a problem hiding this comment.
@jonathansantilli thanks for the update and the contribution!
Contributor
Author
|
It was a pleasure @bbejeck, hope this goes to the master branch soon to test it. |
mjsax
pushed a commit
that referenced
this pull request
Dec 5, 2018
Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>
Contributor
|
@jonathansantilli it's already merged to trunk by @mjsax , you can check out latest trunk head and try it out now :) Thanks for your contributions again! |
mjsax
pushed a commit
that referenced
this pull request
Dec 5, 2018
Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>
mjsax
pushed a commit
that referenced
this pull request
Dec 5, 2018
Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>
Member
|
Merged to |
Member
|
Thanks for the patch @jonathansantilli |
Contributor
Author
|
It was a pleasure @guozhangwang @mjsax |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Reviewers: Matthias J. Sax <matthias@confluent.io>, Bill Bejeck <bill@confluent.io>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check if the Producer is not null to avoid calling producer.close() on a null value.