Skip to content

Unmap before resizing #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lizziew wants to merge 2 commits into from
Closed

Unmap before resizing #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
804116d
Unmap before resizing
lizziew Jul 25, 2013
da110ce
Finetune patch
lizziew Aug 13, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion core/src/main/scala/kafka/log/OffsetIndex.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,11 @@ class OffsetIndex(val file: File, val baseOffset: Long, val maxIndexSize: Int =
}
}

def tryUnmap(m: MappedByteBuffer) {
if(m.isInstanceOf[sun.nio.ch.DirectBuffer])
(m.asInstanceOf[sun.nio.ch.DirectBuffer]).cleaner().clean()
}

/**
* Reset the size of the memory map and the underneath file. This is used in two kinds of cases: (1) in
* trimToValidSize() which is called at closing the segment or new segment being rolled; (2) at
Expand All @@ -259,9 +264,10 @@ class OffsetIndex(val file: File, val baseOffset: Long, val maxIndexSize: Int =
flush()
val raf = new RandomAccessFile(file, "rws")
val roundedNewSize = roundToExactMultiple(newSize, 8)
val position = this.mmap.position
try {
tryUnmap(this.mmap)
raf.setLength(roundedNewSize)
val position = this.mmap.position
this.mmap = raf.getChannel().map(FileChannel.MapMode.READ_WRITE, 0, roundedNewSize)
this.mmap.position(position)
} finally {
Expand Down