Skip to content

MINOR: Add unit for max latency in printf statement#6014

Merged
hachikuji merged 1 commit intoapache:trunkfrom
wicknicks:add-unit-for-statement-prod-perf
Dec 12, 2018
Merged

MINOR: Add unit for max latency in printf statement#6014
hachikuji merged 1 commit intoapache:trunkfrom
wicknicks:add-unit-for-statement-prod-perf

Conversation

@wicknicks
Copy link
Copy Markdown
Contributor

@wicknicks wicknicks commented Dec 7, 2018

This PR adds the unit for a metric.

The change was tested by running the main() method and observing the changed logs in the console.

Signed-off-by: Arjun Satish arjun@confluent.io

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@wicknicks wicknicks force-pushed the add-unit-for-statement-prod-perf branch 2 times, most recently from 4347532 to 953ac1e Compare December 7, 2018 20:58
Signed-off-by: Arjun Satish <arjun@confluent.io>
@wicknicks wicknicks force-pushed the add-unit-for-statement-prod-perf branch from 953ac1e to 35b6be1 Compare December 7, 2018 20:58
@wicknicks
Copy link
Copy Markdown
Contributor Author

@hachikuji @cmccabe any thoughts on this PR? thanks in advance.

Copy link
Copy Markdown
Contributor

@hachikuji hachikuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hachikuji hachikuji merged commit 3ef6b0f into apache:trunk Dec 12, 2018
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants