KAFKA-7708: Fixed KTable tests using KStream API in scala tests#6019
Closed
lodamar wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-7708: Fixed KTable tests using KStream API in scala tests#6019lodamar wants to merge 1 commit intoapache:trunkfrom
lodamar wants to merge 1 commit intoapache:trunkfrom
Conversation
lodamar
changed the title
lodamar
changed the title
vvcephei
approved these changes
Dec 10, 2018
Contributor
vvcephei
left a comment
vvcephei
left a comment
There was a problem hiding this comment.
Oh my gosh, I can't believe I overlooked this before. Thanks for the catch!
Contributor
|
@mjsax , do you mind taking a look, too? |
Member
|
Can you give more context? What is wrong with the tests? It should not matter if the table is create from a changelog or from a stream via group-by-aggregate? What do I miss? |
Author
|
I read another time old tests and you are right. Old tests are right. |
Contributor
|
Ah, well, now I'm doubly embarrassed... Thanks, @mjsax . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After reading https://issues.apache.org/jira/browse/KAFKA-7708 I can confirm KTable scala tests are using KStream API.
I propose this simple PR. I change all builder.stream to builder.table and modify KTable tests accordingly.
KTable scala tests were introduced in: #5502