Skip to content

KAFKA-7223: document suppression buffer metrics#6024

Merged
guozhangwang merged 2 commits intoapache:trunkfrom
vvcephei:document-suppression-buffer-metrics
Dec 13, 2018
Merged

KAFKA-7223: document suppression buffer metrics#6024
guozhangwang merged 2 commits intoapache:trunkfrom
vvcephei:document-suppression-buffer-metrics

Conversation

@vvcephei
Copy link
Copy Markdown
Contributor

Document the new metrics added in #5795

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@vvcephei
Copy link
Copy Markdown
Contributor Author

Excerpt of processor node metrics:
processor-node

New intro for state store metrics:
state-store-1

Relevant new metrics:
state-store-2

Question: It doesn't seem like the suppression metrics fit in that well with the other state store metrics. Should I just make it a separate section, and possibly merge them in the future when there is some overlap?

@vvcephei
Copy link
Copy Markdown
Contributor Author

@guozhangwang @bbejeck , can you take a look at this when you have a chance?

@guozhangwang
Copy link
Copy Markdown
Contributor

@vvcephei let's use a separate section for suppression buffers.

Copy link
Copy Markdown
Member

@bbejeck bbejeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo @guozhangwang's comment about a separate section

@vvcephei
Copy link
Copy Markdown
Contributor Author

Ok @guozhangwang @bbejeck ,

I've moved the buffer metrics to another table:

buffer1

Also removed it from the list of store types:
state-store-3

Lastly, I happened to notice that there's some markdown syntax that got into this file, so I've fixed it by replacing double-backticks with <code> elements.

Copy link
Copy Markdown
Contributor

@guozhangwang guozhangwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@guozhangwang guozhangwang merged commit fdd33bc into apache:trunk Dec 13, 2018
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
Document the new metrics added in apache#5795

Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <wangguoz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants