MINOR:Start processor inside verify message#6029
Conversation
| final StreamsBuilder builder = new StreamsBuilder(); | ||
|
|
||
| final KStream<String, String> sourceStream = builder.stream(inputTopic, Consumed.with(Serdes.String(), Serdes.String())); | ||
| sourceStream.peek((k,v) -> System.out.println(String.format("input data key=%s, value=%s", k, v))); |
There was a problem hiding this comment.
Used for debugging I'd prefer to leave in should the test have problems in the future
|
|
||
| self.zookeeper = ZookeeperService(self.test_context, num_nodes=1) | ||
| self.kafka = KafkaService(self.test_context, num_nodes=1, | ||
| self.kafka = KafkaService(self.test_context, num_nodes=3, |
There was a problem hiding this comment.
Changed this value to be consistent with other system tests
| for processor in processors: | ||
| processor.CLEAN_NODE_ENABLED = False | ||
| self.set_topics(processor) | ||
| processor.start() |
There was a problem hiding this comment.
This is the fix removed start here and below
| with processor.node.account.monitor_log(processor.STDOUT_FILE) as monitor: | ||
| node = processor.node | ||
| with node.account.monitor_log(processor.STDOUT_FILE) as monitor: | ||
| processor.start() |
There was a problem hiding this comment.
This is the other part of the fix moved processor start here
There was a problem hiding this comment.
What's the significance of after opening the monitor? Does it block on the log file somehow?
There was a problem hiding this comment.
This closes a very small timing window, I've made similar changes in other system tests before
There was a problem hiding this comment.
@vvcephei If get don't get the monitor first, we might miss some output lines from the file in wait_until below and thus time out even if the correct output was written.
|
ping @guozhangwang, @mjsax, and @vvcephei for reviews |
|
LGTM! Merged to trunk. |
This PR fixes a flaky system test. I ran six runs of branch builder, and each run was parameterized to repeat the test 25 times for a total of 150 runs. All test runs passed. https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2122/ https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2123/ https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2124/ https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2128/ https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2129/ https://jenkins.confluent.io/job/system-test-kafka-branch-builder/2130/ Reviewers: Matthias J. Sax <matthias@confluent.io>, Guozhang Wang <guozhang@confluent.io>, John Roesler <vvcephei@users.noreply.github.com>
4 participants
This PR fixes a flaky system test.
I ran six runs of branch builder, and each run was parameterized to repeat the test 25 times for a total of 150 runs. All test runs passed.
Committer Checklist (excluded from commit message)