MINOR: Include additional detail in fetch error message#6036
Merged
hachikuji merged 2 commits intoapache:trunkfrom Dec 17, 2018
Merged
MINOR: Include additional detail in fetch error message#6036hachikuji merged 2 commits intoapache:trunkfrom
hachikuji merged 2 commits intoapache:trunkfrom
Conversation
Contributor
|
#6002 @hachikuji could you help me review the pr? thank you |
mumrah
reviewed
Dec 17, 2018
| case OrdinaryConsumerId => "consumer" | ||
| case DebuggingConsumerId => "debug consumer" | ||
| case FutureLocalReplicaId => "future local replica" | ||
| case id if isValidBrokerId(id) => s"replica [$replicaId]" |
Member
There was a problem hiding this comment.
Doesn't really matter, but you have $replicaId here and $id below
|
|
||
| val fetchSource = Request.describeReplicaId(replicaId) | ||
| error(s"Error processing fetch with max size $adjustedMaxBytes from $fetchSource " + | ||
| s"on partition $tp: $fetchInfo", e) |
Member
There was a problem hiding this comment.
Offset is not longer included in this error message. Is that intentional?
Contributor
Author
There was a problem hiding this comment.
It's part of PartitionData.
hachikuji
added a commit
that referenced
this pull request
Dec 18, 2018
This patch adds additional information in the log message after a fetch failure to make debugging easier. Reviewers: David Arthur <mumrah@gmail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
This patch adds additional information in the log message after a fetch failure to make debugging easier. Reviewers: David Arthur <mumrah@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issues such as KAFKA-7656 would be easier to debug if the error message included additional detail about the fetch request.
Committer Checklist (excluded from commit message)