KAFKA-7741: Streams exclude javax dependency#6121
Merged
guozhangwang merged 1 commit intoapache:trunkfrom Jan 10, 2019
vvcephei:KAFKA-7741-exclude-javax
Merged
KAFKA-7741: Streams exclude javax dependency#6121guozhangwang merged 1 commit intoapache:trunkfrom vvcephei:KAFKA-7741-exclude-javax
guozhangwang merged 1 commit intoapache:trunkfrom
vvcephei:KAFKA-7741-exclude-javax
Conversation
Contributor
Author
|
@guozhangwang @mjsax @bbejeck , can you take a look at this when you get a chance? Thanks! |
Contributor
Author
|
I've tested the change like this:
Whereas, replacing |
Contributor
Author
|
once merged, we should cherry-pick this back to 2.0 (the first version in which we published a scala artifact). |
guozhangwang
pushed a commit
that referenced
this pull request
Jan 10, 2019
As documented in https://issues.apache.org/jira/browse/KAFKA-7741, the javax dependency we receive transitively from connect is incompatible with SBT builds. Streams doesn't use the portion of Connect that needs the dependency, so we can fix the builds by simply excluding it. Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <guozhang@confluent.io>
guozhangwang
pushed a commit
that referenced
this pull request
Jan 10, 2019
As documented in https://issues.apache.org/jira/browse/KAFKA-7741, the javax dependency we receive transitively from connect is incompatible with SBT builds. Streams doesn't use the portion of Connect that needs the dependency, so we can fix the builds by simply excluding it. Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <guozhang@confluent.io>
Contributor
|
LGTM! Merged to trunk, and cherry-picked to 2.1 and 2.0. |
Contributor
Author
|
Thanks @guozhangwang and @bbejeck ! |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
As documented in https://issues.apache.org/jira/browse/KAFKA-7741, the javax dependency we receive transitively from connect is incompatible with SBT builds. Streams doesn't use the portion of Connect that needs the dependency, so we can fix the builds by simply excluding it. Reviewers: Bill Bejeck <bill@confluent.io>, Guozhang Wang <guozhang@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As documented in https://issues.apache.org/jira/browse/KAFKA-7741,
the javax dependency we receive transitively from connect is incompatible
with SBT builds.
Streams doesn't use the portion of Connect that needs the dependency,
so we can fix the builds by simply excluding it.
Committer Checklist (excluded from commit message)