KAFKA-7844: Fix installAll, jarAll, etc. targets#6169
Closed
cmccabe wants to merge 3 commits intoapache:trunkfrom
Closed
KAFKA-7844: Fix installAll, jarAll, etc. targets#6169cmccabe wants to merge 3 commits intoapache:trunkfrom
cmccabe wants to merge 3 commits intoapache:trunkfrom
Conversation
The presence of the buildSrc subproject is causing problems when we try to run installAll, jarAll, and the other "all" targets. It's easier just to make the generator code a regular subproject and use the JavaExec gradle task to run the code. This also makes it more straightforward to run the generator unit tests.
Member
|
Checked this out locally and it fixed the IntelliJ errors I was seeing previously. 👍 |
Contributor
Author
|
Note that this also fixes IntelliJ not correctly handling some of the generator junit test files. |
build.gradle: The :generator module should not reference org.apache.kafka.test.IntegrationTest.IntegrationTest, since it resides in the client module which we may not have yet compiled.
Contributor
|
The jenkins failures are consistent, seems relevant? |
Member
|
Yeah, the errors are definitely related. |
Member
|
Adding |
Member
Member
|
Merged #6182 with correct attribution, closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The presence of the buildSrc subproject is causing problems when we try
to run installAll, jarAll, and the other "all" targets. It's easier
just to make the generator code a regular subproject and use the
JavaExec gradle task to run the code. This also makes it more
straightforward to run the generator unit tests.