Skip to content

MINOR: Upgrade ducktape to 0.7.5#6197

Merged
cmccabe merged 2 commits intoapache:trunkfrom
kkonstantine:MINOR-Upgrade-ducktape-to-0.7.5
Jan 25, 2019
Merged

MINOR: Upgrade ducktape to 0.7.5#6197
cmccabe merged 2 commits intoapache:trunkfrom
kkonstantine:MINOR-Upgrade-ducktape-to-0.7.5

Conversation

@kkonstantine
Copy link
Copy Markdown
Contributor

@kkonstantine kkonstantine commented Jan 24, 2019

Upgrade to the latest version of ducktape (0.7.5)
Safe to upgrade branches that already have 0.7.1 (that is 1.0 and ahead)

Tested by running all system tests with version 0.7.5 of ducktape

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@kkonstantine
Copy link
Copy Markdown
Contributor Author

kkonstantine commented Jan 25, 2019

@ewencp @ijuma @cmccabe
ducktape update proceeded smoothly. I believe we can merge back to 1.0 that is the earliest branch using ducktape 0.7.1

@cmccabe
Copy link
Copy Markdown
Contributor

cmccabe commented Jan 25, 2019

LGTM

@cmccabe cmccabe merged commit 0dbb064 into apache:trunk Jan 25, 2019
@kkonstantine kkonstantine deleted the MINOR-Upgrade-ducktape-to-0.7.5 branch January 25, 2019 19:28
asfgit pushed a commit that referenced this pull request Jan 27, 2019
@kkonstantine @cmccabe
MINOR: Upgrade ducktape to 0.7.5 (#6197)
3fae5eb 
Reviewed-by: Colin P. McCabe <cmccabe@apache.org>
(cherry picked from commit 0dbb064)
@cmccabe
Copy link
Copy Markdown
Contributor

cmccabe commented Jan 27, 2019

Backported to 2.1. I'm not sure if we should backport further unless we decide to make a release for one of those older branches.

@kkonstantine
Copy link
Copy Markdown
Contributor Author

kkonstantine commented Jan 28, 2019

Thanks for backporting @cmccabe
Here's a reason to backport even further: this PR affects the system tests that run in every version branch rather than the actual release itself. These system tests run frequently, regardless of release plans.

I noticed that ducktape 0.7.1 was present as far as Kafka v1.0 I believe it's a trivial commit so it seems reasonable to me to backport up to v1.0. The PR that will use ducktape 0.7.5 that was merged here is: #6158 and I believe we should merge heap dump support in system tests also at least as far back as v1.0.

Hope this background helps a bit.

@ewencp
Copy link
Copy Markdown
Contributor

ewencp commented Feb 5, 2019

Cherry-picking to 2.0, 1.1, and 1.0. Some older branches need another minor update to pin the pip version, which for some reason looks like it was only backported to 2.0 but leaves ducker in a broken state.

ewencp pushed a commit that referenced this pull request Feb 5, 2019
@kkonstantine @ewencp
MINOR: Upgrade ducktape to 0.7.5 (#6197)
47bb1a4 
Reviewed-by: Colin P. McCabe <cmccabe@apache.org>
ewencp pushed a commit that referenced this pull request Feb 5, 2019
@kkonstantine @ewencp
MINOR: Upgrade ducktape to 0.7.5 (#6197)
693993d 
Reviewed-by: Colin P. McCabe <cmccabe@apache.org>
ewencp pushed a commit that referenced this pull request Feb 5, 2019
@kkonstantine @ewencp
MINOR: Upgrade ducktape to 0.7.5 (#6197)
4ce05d9 
Reviewed-by: Colin P. McCabe <cmccabe@apache.org>
jarekr pushed a commit to confluentinc/kafka that referenced this pull request Apr 18, 2019
@dhruvilshah3
Merge remote-tracking branch 'ak/trunk' into cos-trunk
cdea633 
* ak/trunk:
  MINOR: Update usage of deprecated API (apache#6146)
  KAFKA-4217: Add KStream.flatTransform (apache#5273)
  MINOR: Update Gradle to 5.1.1 (apache#6160)
  KAFKA-3522: Generalize Segments (apache#6170)
  Added quotes around the class path (apache#4469)
  KAFKA-7837: Ensure offline partitions are picked up as soon as possible when shrinking ISR (apache#6202)
  MINOR: In the MetadataResponse schema, ignorable should be a boolean
  KAFKA-7838: Log leader and follower end offsets when shrinking ISR (apache#6168)
  KAFKA-5692: Change PreferredReplicaLeaderElectionCommand to use Admin… (apache#3848)
  MINOR: clarify why suppress can sometimes drop tombstones (apache#6195)
  MINOR: Upgrade ducktape to 0.7.5 (apache#6197)
  MINOR: Improve IntegrationTestUtils documentation (apache#5664)
  MINOR: upgrade to jdk8 8u202
  KAFKA-7693; Fix SequenceNumber overflow in producer (apache#5989)
  KAFKA-7692; Fix ProducerStateManager SequenceNumber overflow (apache#5990)
  MINOR: update copyright year in the NOTICE file. (apache#6196)
  KAFKA-7793: Improve the Trogdor command line. (apache#6133)
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
@kkonstantine @pengxiaolong
MINOR: Upgrade ducktape to 0.7.5 (apache#6197)
11d0e18 
Reviewed-by: Colin P. McCabe <cmccabe@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kkonstantine @cmccabe @ewencp