MINOR: Remove deprecated assertThat method usage from KafkaLog4jAppenderTest#6257
Merged
ijuma merged 1 commit intoapache:trunkfrom Feb 12, 2019
Merged
MINOR: Remove deprecated assertThat method usage from KafkaLog4jAppenderTest#6257ijuma merged 1 commit intoapache:trunkfrom
ijuma merged 1 commit intoapache:trunkfrom
Conversation
omkreddy
changed the title
omkreddy
changed the title
Contributor
Author
rajinisivaram
approved these changes
Feb 12, 2019
Contributor
rajinisivaram
left a comment
rajinisivaram
left a comment
There was a problem hiding this comment.
@omkreddy Thanks for the PR, LGTM
Member
|
Thanks, looks like the two PRs were merged somewhat concurrently. Will merge this now since it's just a compilation fix and that part has succeeded. |
This was referenced Feb 12, 2019
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…apache#6257) Replace `Assert.assertThat` with `MatcherAssert.assertThat`. Two commits (08036fa and c7f99bc) were merged at a similar time and they passed the build in isolation, but not together. Reviewers: Rajini Sivaram <rajinisivaram@googlemail.com>, Ismael Juma <ismael@juma.me.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assert.assertThatwithMatcherAssert.assertThat.Committer Checklist (excluded from commit message)