KAFKA-7963: Extract hard-coded Streams metric name strings to centralized place#6355
Merged
bbejeck merged 1 commit intoapache:trunkfrom Mar 6, 2019
Merged
Conversation
Member
Author
Member
|
\cc @vvcephei |
Member
Author
|
First pass found only these two strings appearing in more than one file (in the context of StreamsMetricsImpl#XXLevelSensor() calls) but there may be others worth including in this scope..? |
mjsax
approved these changes
Mar 2, 2019
Member
Author
|
Failures unrelated: retest this, please |
Member
|
Known flaky test failed: https://issues.apache.org/jira/browse/KAFKA-7978 Retest this please. |
Contributor
Member
|
Merged #6355 into trunk |
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
…apache#6355) Moved hard-coded 'expired-window-record-drop' and 'late-record-drop' to static Strings in StreamsMetricsImpl Reviewers: Guozhang Wang <wangguoz@gmail.com>, Matthias J. Sax <mjsax@apache.org>, Bill Bejeck <bbejeck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved hard-coded 'expired-window-record-drop' and 'late-record-drop' to static Strings in StreamsMetricsImpl
Committer Checklist (excluded from commit message)