KAFKA-8040: Streams handle initTransactions timeout#6416
Merged
bbejeck merged 2 commits intoapache:2.0from Mar 11, 2019
vvcephei:KAFKA-8040-streams-retry-initTransactions-2.0-cherry
Merged
KAFKA-8040: Streams handle initTransactions timeout#6416bbejeck merged 2 commits intoapache:2.0from vvcephei:KAFKA-8040-streams-retry-initTransactions-2.0-cherry
bbejeck merged 2 commits intoapache:2.0from
vvcephei:KAFKA-8040-streams-retry-initTransactions-2.0-cherry
Conversation
As of 2.0, Producer.initTransactions may throw a TimeoutException, which is retriable. Streams should retry instead of crashing when we encounter this exception Reviewers: Guozhang Wang <wangguoz@gmail.com>, Matthias J. Sax <mjsax@apache.org>, Bill Bejeck <bbejeck@gmail.com> See #6372
Contributor
Author
Member
|
@vvcephei failure is related - checkstyle |
Member
|
\cc @ableegoldman for review |
guozhangwang
approved these changes
Mar 9, 2019
Contributor
|
retest this please |
Member
|
@vvcephei just two minor checkstyle failures |
Contributor
Author
|
Oops! Thanks for capturing those, @bbejeck |
Member
|
Merged #6416 into |
Contributor
Author
|
Thanks, @bbejeck ! |
vvcephei
deleted the
KAFKA-8040-streams-retry-initTransactions-2.0-cherry
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of 2.0, Producer.initTransactions may throw a TimeoutException, which is retriable. Streams should retry instead of crashing when we encounter this exception
Reviewers: Guozhang Wang wangguoz@gmail.com, Matthias J. Sax mjsax@apache.org, Bill Bejeck bbejeck@gmail.com
Cherry-pick of #6372
Committer Checklist (excluded from commit message)