Skip to content

KAFKA-8026: Fix flaky regex source integration test 1.0#6463

Merged
bbejeck merged 2 commits intoapache:1.0from
bbejeck:KAFKA-8026_fix_flaky_regex_source_integration_test_1_0
Mar 25, 2019
Merged

KAFKA-8026: Fix flaky regex source integration test 1.0#6463
bbejeck merged 2 commits intoapache:1.0from
bbejeck:KAFKA-8026_fix_flaky_regex_source_integration_test_1_0

Conversation

@bbejeck
Copy link
Copy Markdown
Member

@bbejeck bbejeck commented Mar 18, 2019

This PR is an attempt to fix the RegexSourceIntegrationTest flakiness. My investigation did not reveal any issues, and I was unable to reproduce the failure locally. So I've taken some steps to eliminate what I think could be a race condition in the test.

This is a mirror image of #6459 and is the fix for 1.0

  1. Delete and create all topics before each test starts.
  2. Give the streams application in each test a unique application ID
  3. Create a KafkaStreams instance local to each test.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Mar 18, 2019

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Mar 18, 2019

Java 7 and Java 8 passed. Java 10 failed.

retest this please

Copy link
Copy Markdown
Member

@mjsax mjsax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Mar 20, 2019

Unrelated test failures in Java10. Java7 timed out. Java8 passed.

Retest this please.

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Mar 20, 2019

I think Java10 cannot pass on older branches. LGTM.

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Mar 20, 2019

Java 7 and 8 passed, Java 10 failures unrelated.

retest this please.

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Mar 20, 2019

@mjsax I've fixed the ConcurrentModificationException manually, can you take another look?

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Mar 20, 2019

Java 7 passed, Java 8 and 10 failures unrelateed

retest this please

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Mar 20, 2019

Still +1 (note, I think that Java10 cannot pass Jenkins on 1.0 branch -- this older branch is not compatible)

Call for second review anyof @guozhangwang @vvcephei @ableegoldman

@bbejeck
Copy link
Copy Markdown
Member Author

bbejeck commented Mar 20, 2019

Java 7 passed Java 8 failed 2:21:25 Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)

retest this please

Copy link
Copy Markdown
Contributor

@vvcephei vvcephei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bbejeck . Just one small thought... Feel free to adopt or ignore it!

CLUSTER.bootstrapServers(),
STRING_SERDE_CLASSNAME,
STRING_SERDE_CLASSNAME,
properties);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also purge the local state before tests, just in case.

@bbejeck bbejeck merged commit 7434ef1 into apache:1.0 Mar 25, 2019
@bbejeck bbejeck deleted the KAFKA-8026_fix_flaky_regex_source_integration_test_1_0 branch March 25, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants