MINOR: fix core test build#6603
Merged
hachikuji merged 2 commits intoapache:trunkfrom Apr 18, 2019
vvcephei:MINOR-fix-build
Merged
MINOR: fix core test build#6603hachikuji merged 2 commits intoapache:trunkfrom vvcephei:MINOR-fix-build
hachikuji merged 2 commits intoapache:trunkfrom
vvcephei:MINOR-fix-build
Conversation
Contributor
Author
|
Hi @hachikuji , do you mind taking a look at this? (warning: I ran that one test, but not all the tests, locally before pushing this PR) |
3 tasks
hachikuji
reviewed
Apr 18, 2019
| val relativeOffset = (startOffset - segmentBaseOffset).toInt | ||
| val producerAppendInfo = new ProducerAppendInfo(producerId, ProducerStateEntry.empty(producerId), ValidationType.Full) | ||
| val producerAppendInfo = new ProducerAppendInfo( | ||
| new TopicPartition("test", 0), |
Contributor
There was a problem hiding this comment.
Can we just use partition?
Contributor
Author
There was a problem hiding this comment.
oh, sure; I overlooked it.
hachikuji
approved these changes
Apr 18, 2019
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this. I verified the fix locally, so I will go ahead and merge.
This was referenced Apr 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)