KAFKA-8240: Fix NPE in Source.equals()#6685
Merged
mjsax merged 1 commit intoapache:2.2from May 9, 2019
Merged
Conversation
Member
mjsax
commented
May 6, 2019
mjsax
commented
- backport of PR KAFKA-8240: Fix NPE in Source.equals() #6589 to 2.2 branch
- backport of PR apache#6589 to 2.2 branch
Member
Author
mjsax
commented
May 6, 2019
| } | ||
|
|
||
| @Test | ||
| public void shouldThrowIfNameIsNull() { |
Member
Author
There was a problem hiding this comment.
Needed to rewrite those tests, because we use JUnit 4.12 in 2.2 branch (instead of 4.13-beta-2 as in trunk) that does not support assertThrows.
Upgrading JUnit to 4.13-beta-2 broke other tests so it's easier to stick with 4.12.
|
SUCCESS |
cadonna
approved these changes
May 7, 2019
Member
Author
|
Java8 never started or never finished... (is in "yellow" pending state for half a day) Java11 passed. Retest this please. |
Member
|
Failures seem unrelated. Retest this, please |
mjsax
added a commit
that referenced
this pull request
May 9, 2019
- backport of PR #6589 to 2.2 branch Reviewers: Bruno Cadonna <bruno@confluent.io>, Bill Bejeck <bill@confluent.io>
Member
Author
|
Merged to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.