MINOR: Add test for ConsumerNetworkClient.trySend#6739
Merged
hachikuji merged 2 commits intoapache:trunkfrom May 17, 2019
Merged
MINOR: Add test for ConsumerNetworkClient.trySend#6739hachikuji merged 2 commits intoapache:trunkfrom
hachikuji merged 2 commits intoapache:trunkfrom
Conversation
Contributor
|
retest this please |
hachikuji
reviewed
May 16, 2019
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Thanks for the test case. Left two small comments, but looks good otherwise.
|
|
||
| consumerClient.trySend(time.milliseconds()); | ||
| // only check one time when the node doesn't ready | ||
| assertEquals(checkCount.getAndSet(0), 1); |
Contributor
There was a problem hiding this comment.
nit: the expectation should be the first argument
| */ | ||
| package org.apache.kafka.clients.consumer.internals; | ||
|
|
||
| import org.apache.kafka.clients.ClientRequest; |
Contributor
There was a problem hiding this comment.
This import was not needed, so checkstyle is failing.
lambdaliu
force-pushed
the
add_ConsumerNetworkClient_trySend_test
branch
from
e99566a to
3e50e73
Compare
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Reviewers: Jason Gustafson <jason@confluent.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add test for the change of ConsumerNetworkClient.trySend in #6264,
Committer Checklist (excluded from commit message)