KAFKA-8265 : Fix config name to match KIP-458, Return a copy of the ConfigDef in Client Configs.#6755
Merged
rhauch merged 1 commit intoapache:trunkfrom May 20, 2019
Merged
Conversation
Return a copy of the ConfigDef in Client Configs.
Contributor
Author
|
@rhauch when you get a chance, can you take a look at this minor fix for KIP-458. |
rhauch
approved these changes
May 17, 2019
Contributor
rhauch
left a comment
rhauch
left a comment
There was a problem hiding this comment.
LGTM. Thanks for catching these issues.
Contributor
Author
|
@ijuma I have addressed the mutability issue that you had raised in the original PR. Let me know if this looks good. |
Member
|
@rhauch this must be cherry-picked to the 2.3 branch also. |
rhauch
pushed a commit
that referenced
this pull request
May 22, 2019
Return a copy of the ConfigDef in Client Configs. Related to KIP-458. Author: Magesh Nandakumar <magesh.n.kumar@gmail.com Reviewer: Randall Hauch <rhauch@gmail.com>
pengxiaolong
pushed a commit
to pengxiaolong/kafka
that referenced
this pull request
Jun 14, 2019
Return a copy of the ConfigDef in Client Configs. Related to KIP-458. Author: Magesh Nandakumar <magesh.n.kumar@gmail.com Reviewer: Randall Hauch <rhauch@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the initial implementation for KIP-458 #6624, the config name was incorrect and not consistent with what was specified in the KIP. This PR fixes the inconsistency.
There was also a concern raised about the mutability of
ConfigDefin #6624 (review). I have made an attempt to fix it by returning a copy every time.Committer Checklist (excluded from commit message)