Skip to content

KAFKA-8415: Interface ConnectorClientConfigOverridePolicy needs to be excluded from class loading isolation#6796

Merged
rhauch merged 1 commit intoapache:trunkfrom
kkonstantine:KAFKA-8415
May 23, 2019
Merged

KAFKA-8415: Interface ConnectorClientConfigOverridePolicy needs to be excluded from class loading isolation#6796
rhauch merged 1 commit intoapache:trunkfrom
kkonstantine:KAFKA-8415

Conversation

@kkonstantine
Copy link
Copy Markdown
Contributor

  • New Connect plugin interface ConnectorClientConfigOverridePolicy needs to be excluded from the class loading isolation

  • Added missing unit tests similar to the ones existing for previous plugins

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@kkonstantine
Copy link
Copy Markdown
Contributor Author

kkonstantine commented May 23, 2019

@rhauch this is a regression after introducing this new plugin, and needs to be backported to 2.3. Thanks!

@kkonstantine
Copy link
Copy Markdown
Contributor Author

cc @mageshn since this plugin was introduced by KIP-458

@rhauch
Copy link
Copy Markdown
Contributor

rhauch commented May 23, 2019

@kkonstantine KIP-458 specifies that these should be loaded via the plugin framework. IIUC, this only affects the built-in policies provided out of the box, which we want to load via the system classloader. Is that right?

@kkonstantine
Copy link
Copy Markdown
Contributor Author

@rhauch this fix aligns this new plugin to what we do for the other plugins, such as Transformation, ConfigProvider or ConnectRestExtension. The interface which we use to scan for plugins needs to be excluded because it's first loaded during the class scanning phase. Same as the other org.apache.kafka classes. But some of the subclasses such as transformations and here the concrete policies needed indeed to be loaded in isolation, so that's why it makes sense to add to the whitelist.

@rhauch rhauch merged commit 68a3eb3 into apache:trunk May 23, 2019
rhauch pushed a commit that referenced this pull request May 23, 2019
… excluded from class loading isolation (#6796)

Author: Konstantine Karantasis <konstantine@confluent.io>
Reviewer: Randall Hauch <rhauch@gmail.com>
@kkonstantine kkonstantine deleted the KAFKA-8415 branch May 23, 2019 19:56
haidangdam pushed a commit to haidangdam/kafka that referenced this pull request May 29, 2019
… excluded from class loading isolation (apache#6796)

Author: Konstantine Karantasis <konstantine@confluent.io>
Reviewer: Randall Hauch <rhauch@gmail.com>
pengxiaolong pushed a commit to pengxiaolong/kafka that referenced this pull request Jun 14, 2019
… excluded from class loading isolation (apache#6796)

Author: Konstantine Karantasis <konstantine@confluent.io>
Reviewer: Randall Hauch <rhauch@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants