MINOR: Remove stale streams producer retry default docs.#6844
Merged
bbejeck merged 1 commit intoapache:trunkfrom Jul 19, 2019
Merged
MINOR: Remove stale streams producer retry default docs.#6844bbejeck merged 1 commit intoapache:trunkfrom
bbejeck merged 1 commit intoapache:trunkfrom
Conversation
Contributor
Author
mjsax
approved these changes
Jun 3, 2019
Member
mjsax
left a comment
mjsax
left a comment
There was a problem hiding this comment.
LGTM.
Only committers can assign reviews and assign labels. Would you mind to do a PR against https://github.com/apache/kafka-site, too, to get this fixed immediately on the webpage, too?
This should be cherry-picked back to 2.1 when we dropped setting producer retries to 10.
Contributor
Author
|
Update to kafka-site: apache/kafka-site#213 |
Member
|
Call for second review: @guozhangwang @bbejeck @vvcephei @ableegoldman @abbccdda |
ableegoldman
approved these changes
Jul 16, 2019
bbejeck
approved these changes
Jul 19, 2019
Member
|
Merged #6844 into trunk |
bbejeck
pushed a commit
that referenced
this pull request
Jul 19, 2019
As part of #5425 the streams default override for producer retries was removed. The documentation was not updated to reflect that change. Reviewers: Matthias J. Sax <mjsax@apache.org>, Sophie Blee-Goldman <sophie@confluent.io>, Bill Bejeck <bbejeck@gmail.com>
bbejeck
pushed a commit
that referenced
this pull request
Jul 19, 2019
As part of #5425 the streams default override for producer retries was removed. The documentation was not updated to reflect that change. Reviewers: Matthias J. Sax <mjsax@apache.org>, Sophie Blee-Goldman <sophie@confluent.io>, Bill Bejeck <bbejeck@gmail.com>
bbejeck
pushed a commit
that referenced
this pull request
Jul 19, 2019
As part of #5425 the streams default override for producer retries was removed. The documentation was not updated to reflect that change. Reviewers: Matthias J. Sax <mjsax@apache.org>, Sophie Blee-Goldman <sophie@confluent.io>, Bill Bejeck <bbejeck@gmail.com>
Member
|
cherry-picked to 2.3, 2.2, and 2.1 |
bbejeck
pushed a commit
to apache/kafka-site
that referenced
this pull request
Jul 19, 2019
These default overrides are no longer applied, see: apache/kafka#6844. CC: Updated for 2.2 and 2.1
ijuma
added a commit
to confluentinc/kafka
that referenced
this pull request
Jul 20, 2019
* apache-github/2.3: MINOR: Update documentation for enabling optimizations (apache#7099) MINOR: Remove stale streams producer retry default docs. (apache#6844) KAFKA-8635; Skip client poll in Sender loop when no request is sent (apache#7085) KAFKA-8615: Change to track partition time breaks TimestampExtractor (apache#7054) KAFKA-8670; Fix exception for kafka-topics.sh --describe without --topic mentioned (apache#7094) KAFKA-8602: Separate PR for 2.3 branch (apache#7092) KAFKA-8530; Check for topic authorization errors in OffsetFetch response (apache#6928) KAFKA-8662; Fix producer metadata error handling and consumer manual assignment (apache#7086) KAFKA-8637: WriteBatch objects leak off-heap memory (apache#7050) KAFKA-8620: fix NPE due to race condition during shutdown while rebalancing (apache#7021) HOT FIX: close RocksDB objects in correct order (apache#7076) KAFKA-7157: Fix handling of nulls in TimestampConverter (apache#7070) KAFKA-6605: Fix NPE in Flatten when optional Struct is null (apache#5705) Fixes apache#8198 KStreams testing docs use non-existent method pipe (apache#6678) KAFKA-5998: fix checkpointableOffsets handling (apache#7030) KAFKA-8653; Default rebalance timeout to session timeout for JoinGroup v0 (apache#7072) KAFKA-8591; WorkerConfigTransformer NPE on connector configuration reloading (apache#6991) MINOR: add upgrade text (apache#7013) Bump version to 2.3.1-SNAPSHOT
xiowu0
pushed a commit
to linkedin/kafka
that referenced
this pull request
Aug 22, 2019
… default docs. (apache#6844) TICKET = LI_DESCRIPTION = EXIT_CRITERIA = HASH [aa1a285] ORIGINAL_DESCRIPTION = As part of apache#5425 the streams default override for producer retries was removed. The documentation was not updated to reflect that change. Reviewers: Matthias J. Sax <mjsax@apache.org>, Sophie Blee-Goldman <sophie@confluent.io>, Bill Bejeck <bbejeck@gmail.com> (cherry picked from commit aa1a285)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of #5425 the streams default override for producer retries was removed. The documentation was not updated to reflect that change.
Committer Checklist (excluded from commit message)