KAFKA-8564: Fix NPE on deleted partition dirs#6968
Merged
hachikuji merged 2 commits intoapache:trunkfrom Jun 19, 2019
Merged
Conversation
Kafka should not NPE while loading a deleted partition dir with no log segments Co-authored-by: Edoardo Comar <ecomar@uk.ibm.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com>
ijuma
reviewed
Jun 19, 2019
| logDir.mkdirs() | ||
| val logConfig = LogTest.createLogConfig() | ||
| // There was a regression in 2.2.1 which threw an NPE | ||
| val log = createLog(logDir, logConfig) |
Member
There was a problem hiding this comment.
Can we assert something about the log? If not, then we should remove the val.
ijuma
reviewed
Jun 19, 2019
| val logDir = new File(tmpDir, dirName) | ||
| logDir.mkdirs() | ||
| val logConfig = LogTest.createLogConfig() | ||
| // There was a regression in 2.2.1 which threw an NPE |
Member
There was a problem hiding this comment.
I don't think this comment adds much value.
Member
|
Nice catch! |
hachikuji
approved these changes
Jun 19, 2019
Contributor
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
Thanks, LGTM. Left two small comments in the test case.
| logDir.mkdirs() | ||
| val logConfig = LogTest.createLogConfig() | ||
| // There was a regression in 2.2.1 which threw an NPE | ||
| val log = createLog(logDir, logConfig) |
Contributor
There was a problem hiding this comment.
Maybe add an assertion that there is exactly one log segment?
| val logDir = new File(tmpDir, dirName) | ||
| logDir.mkdirs() | ||
| val logConfig = LogTest.createLogConfig() | ||
| // There was a regression in 2.2.1 which threw an NPE |
Contributor
There was a problem hiding this comment.
nit: I don't think we need to mention this in the code. We have the git history and JIRA already.
Member
Author
|
Thanks for the quick reviews! I've pushed an update |
Contributor
|
@mimaison Thanks for the update. I will merge after the build completes. |
hachikuji
pushed a commit
that referenced
this pull request
Jun 19, 2019
…6968) Kafka should not NPE while loading a deleted partition dir with no log segments. This patch ensures that there will always be at least one segment after initialization. Co-authored-by: Edoardo Comar <ecomar@uk.ibm.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
Jun 19, 2019
…6968) Kafka should not NPE while loading a deleted partition dir with no log segments. This patch ensures that there will always be at least one segment after initialization. Co-authored-by: Edoardo Comar <ecomar@uk.ibm.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
Jun 19, 2019
…6968) Kafka should not NPE while loading a deleted partition dir with no log segments. This patch ensures that there will always be at least one segment after initialization. Co-authored-by: Edoardo Comar <ecomar@uk.ibm.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
hachikuji
pushed a commit
that referenced
this pull request
Jun 19, 2019
…6968) Kafka should not NPE while loading a deleted partition dir with no log segments. This patch ensures that there will always be at least one segment after initialization. Co-authored-by: Edoardo Comar <ecomar@uk.ibm.com> Co-authored-by: Mickael Maison <mickael.maison@gmail.com> Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
Contributor
|
I'd like to understand why the |
Contributor
|
looks like appending the |
Contributor
|
the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kafka should not NPE while loading a deleted partition dir with no log segments
Co-authored-by: Edoardo Comar ecomar@uk.ibm.com
Co-authored-by: Mickael Maison mickael.maison@gmail.com
Committer Checklist (excluded from commit message)