Skip to content

MINOR: Disable scoverage in 2.0#6980

Merged
hachikuji merged 1 commit intoapache:2.0from
hachikuji:disable-scoverage
Jun 21, 2019
Merged

MINOR: Disable scoverage in 2.0#6980
hachikuji merged 1 commit intoapache:2.0from
hachikuji:disable-scoverage

Conversation

@hachikuji
Copy link
Copy Markdown
Contributor

The scoverage plugin is causing the build to fail with recent versions of gradle. I see the following error:

* What went wrong:
A problem occurred evaluating root project 'kafka'.
> Failed to apply plugin [id 'org.scoverage']
   > Could not create an instance of type org.scoverage.ScoverageExtension.
      > You can't map a property that does not exist: propertyName=testClassesDir

This patch disables the plugin since we are not typically checking coverage for old branches anyway.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@hachikuji
Copy link
Copy Markdown
Contributor Author

retest this please

Copy link
Copy Markdown
Member

@ijuma ijuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hachikuji
Copy link
Copy Markdown
Contributor Author

retest this please

@hachikuji hachikuji merged commit edc7e02 into apache:2.0 Jun 21, 2019
gardnervickers pushed a commit to gardnervickers/kafka-1 that referenced this pull request Jul 3, 2019
The scoverage plugin is causing the build to fail with recent versions of gradle. I see the following error:
```
* What went wrong:
A problem occurred evaluating root project 'kafka'.
> Failed to apply plugin [id 'org.scoverage']
   > Could not create an instance of type org.scoverage.ScoverageExtension.
      > You can't map a property that does not exist: propertyName=testClassesDir
```
This patch disables the plugin since we are not typically checking coverage for old branches anyway.

Reviewers: Ismael Juma <ismael@juma.me.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants