Skip to content

KAFKA-8618: Replace Txn marker with automated protocol#7039

Merged
mimaison merged 2 commits intoapache:trunkfrom
abbccdda:txn_marker
Mar 19, 2020
Merged

KAFKA-8618: Replace Txn marker with automated protocol#7039
mimaison merged 2 commits intoapache:trunkfrom
abbccdda:txn_marker

Conversation

@abbccdda
Copy link
Copy Markdown

@abbccdda abbccdda commented Jul 7, 2019

As title. This one is tricky because the original txn marker entry has been widely used, so we choose to minimize the change by making the transformation internal for the txn marker class.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@abbccdda abbccdda force-pushed the txn_marker branch 3 times, most recently from b629f53 to 7ab4850 Compare January 10, 2020 17:14
@hachikuji
Copy link
Copy Markdown
Contributor

hachikuji commented Jan 15, 2020

retest this please

1 similar comment
@hachikuji
Copy link
Copy Markdown
Contributor

hachikuji commented Jan 30, 2020

retest this please

@abbccdda
Copy link
Copy Markdown
Author

abbccdda commented Jan 30, 2020

Checked both test failures are flaky

@hachikuji
Copy link
Copy Markdown
Contributor

hachikuji commented Feb 3, 2020

retest this please

1 similar comment
@abbccdda
Copy link
Copy Markdown
Author

abbccdda commented Feb 6, 2020

retest this please

@hachikuji
Copy link
Copy Markdown
Contributor

hachikuji commented Feb 6, 2020

ok to test

@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Feb 7, 2020

retest this please

@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Feb 11, 2020

test this please

@abbccdda
Copy link
Copy Markdown
Author

abbccdda commented Feb 11, 2020 •
edited
Loading

Got 1/2 green build https://builds.apache.org/job/kafka-pr-jdk11-scala2.13/4641/
The two failure test cases for the other build are flaky ones:
https://builds.apache.org/job/kafka-pr-jdk8-scala2.12/628/

@abbccdda
Copy link
Copy Markdown
Author

abbccdda commented Mar 13, 2020

@mimaison Hey Mickael, could you take a look of this PR?

mimaison
mimaison requested changes Mar 13, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mimaison mimaison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abbccdda
I've made a quick pass and left a few small comments

Comment thread clients/src/main/java/org/apache/kafka/common/requests/WriteTxnMarkersResponse.java Outdated
Comment thread clients/src/test/java/org/apache/kafka/common/requests/WriteTxnMarkersRequestTest.java Outdated
Comment thread clients/src/test/java/org/apache/kafka/common/requests/WriteTxnMarkersResponseTest.java Outdated
Comment thread clients/src/main/java/org/apache/kafka/common/requests/WriteTxnMarkersRequest.java Outdated
@abbccdda
Copy link
Copy Markdown
Author

abbccdda commented Mar 14, 2020

@mimaison Thanks for the review, addressed.

@mimaison
Copy link
Copy Markdown
Member

mimaison commented Mar 15, 2020

retest this please

1 similar comment
@mimaison
Copy link
Copy Markdown
Member

mimaison commented Mar 15, 2020

retest this please

@abbccdda
Copy link
Copy Markdown
Author

abbccdda commented Mar 16, 2020

@mimaison Could you help trigger another test?

@mimaison
Copy link
Copy Markdown
Member

mimaison commented Mar 16, 2020

retest this please

@abbccdda
Copy link
Copy Markdown
Author

abbccdda commented Mar 16, 2020

@mimaison Looks like the Jenkins jobs are killed, mind kicking off another one?

@mimaison
Copy link
Copy Markdown
Member

mimaison commented Mar 16, 2020

retest this please

@abbccdda
Copy link
Copy Markdown
Author

abbccdda commented Mar 17, 2020

@mimaison Do you mind triggering another test? The PR was rebased to include two broken unit test changes landed yesterday.

@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Mar 17, 2020

test this please

2 similar comments
@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Mar 17, 2020

test this please

@guozhangwang
Copy link
Copy Markdown
Contributor

guozhangwang commented Mar 17, 2020

test this please

@abbccdda
Copy link
Copy Markdown
Author

abbccdda commented Mar 17, 2020

Looks like the test was flaky and not related: org.apache.kafka.streams.processor.internals.StateDirectoryTest.shouldReturnEmptyArrayIfListFilesReturnsNull
Which is actively being fixed: #8310

@mimaison Let me know if you think we should kick off another test just for sanity

@mimaison
Copy link
Copy Markdown
Member

mimaison commented Mar 17, 2020

Thanks for thr updates @abbccdda. I plan to take another look this week

@abbccdda
Copy link
Copy Markdown
Author

abbccdda commented Mar 18, 2020

Rebased

@mimaison
Copy link
Copy Markdown
Member

mimaison commented Mar 19, 2020

retest this please

@mimaison mimaison merged commit c7164a3 into apache:trunk Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mimaison mimaison mimaison approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abbccdda @hachikuji @guozhangwang @mimaison