KAFKA-8644. The Kafka protocol generator should allow null defaults for bytes and array fields#7059
Closed
cmccabe wants to merge 1 commit intoapache:trunkfrom
Closed
KAFKA-8644. The Kafka protocol generator should allow null defaults for bytes and array fields#7059cmccabe wants to merge 1 commit intoapache:trunkfrom
cmccabe wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
There was a problem hiding this comment.
typo: "for a byte field", right?
…or bytes and array fields
Contributor
|
LGTM. Thank you for the patch and the review. |
bfncs
pushed a commit
to bfncs/kafka
that referenced
this pull request
Jul 12, 2019
…or bytes and array fields Author: Colin P. Mccabe <cmccabe@confluent.io> Reviewers: Stanislav Kozlovski, Gwen Shapira Closes apache#7059 from cmccabe/KAFKA-8644
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.