KAFKA-8643: bring back public MemberDescription constructor#7060
KAFKA-8643: bring back public MemberDescription constructor#7060hachikuji merged 5 commits intoapache:trunkfrom
Conversation
abbccdda
force-pushed
the
member_description
branch
from
d8e5e85 to
54d3088
Compare
|
@ijuma @hachikuji FYI |
|
Thanks for the PR. The comments seem a bit weird, binary compatibility is a requirement when changing classes that are part of the public API. Adding the comments to an arbitrary subset adds confusion in my opinion. Also, did the KIP state that the constructor would be deprecated? |
|
@ijuma I agree that we don't need extra comment. And the KIP didn't state that we want to deprecate the constructor. Just add back the constructor to fix the problem only. |
|
@hachikuji Thanks for the catch. Addressed! |
|
Can we please add a test that verifies the |
abbccdda
force-pushed
the
member_description
branch
from
6ffd125 to
ca72235
Compare
abbccdda
force-pushed
the
member_description
branch
from
ca72235 to
06ea20c
Compare
|
@ijuma Thanks for the suggestion, added |
|
Triggering a build through reopening. |
|
retest this please |
abbccdda
force-pushed
the
member_description
branch
from
fb8de8f to
41f97f0
Compare
|
The only failure is |
hachikuji
left a comment
hachikuji
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the patch!
) This patch fixes a compatibility breaking `MemberDescription` constructor change in apache#6957. It also updates `equals` and `hashCode` for the new `groupInstanceId` field that was added in the same patch. Reviewers: Ismael Juma <ismael@juma.me.uk>, Jason Gustafson <jason@confluent.io>
3 participants
a compatibility fix aiming to avoid breaking user's code by accidentally removing a public constructor.
Committer Checklist (excluded from commit message)