KAFKA-8651: Add predicate map to #branch#7068
Closed
astubbs wants to merge 6 commits intoapache:trunkfrom
Closed
Conversation
astubbs
force-pushed
the
astubbs-predicate-map
branch
from
b1f701e to
5e6488a
Compare
Member
|
Closed and reopened to get Jenkins up and running. |
Contributor
Author
|
please retest |
Member
|
@astubbs -- Any progress on the KIP? |
Member
|
Btw: there is a similar KIP already: https://cwiki.apache.org/confluence/display/KAFKA/KIP-418%3A+A+method-chaining+way+to+branch+KStream |
Member
|
I just double checked. KIP-418 was abandoned. Feel free to pick it up to push it over the finish line. |
Member
|
Closing this PR in favor of #9107 (that is backed by KIP-418). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using #branch with an array is error prone and not readable, due to referencing the results by magic index offsets. So, we suggest to add an API that allows naming different branches, which is more natural.
See KIP (on it's way)
Committer Checklist (excluded from commit message)