MINOR: kafkatest - adding whitelist for interbroker sasl configs#7093
MINOR: kafkatest - adding whitelist for interbroker sasl configs#7093rajinisivaram merged 4 commits intoapache:trunkfrom
Conversation
rajinisivaram
left a comment
There was a problem hiding this comment.
@brianbushree Thanks for the PR. Can we add a method to ListenerSecurityConfig and use that rather than duplicate the checks that need to be kept consistent?
rajinisivaram
left a comment
There was a problem hiding this comment.
@brianbushree Thanks for the PR, LGTM. Have we run some SASL system tests with these changes? Don't need a full run, but it will be good to run some tests that use SASL listeners.
|
@rajinisivaram still need to do some validation on my end. let me run some tests before we merge |
|
@rajinisivaram the tests seem fine to me ( http://confluent-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/2019-07-19--001.1563561379--brianbushree--interbroker-sasl-fix--4bfb6ff/report.html ) there was one failure but it seems unrelated: |
|
@brianbushree Thanks for running the test, merging to trunk. |
forgot to include this line in #7018
Committer Checklist (excluded from commit message)