Skip to content

KAFKA-8602: Backport bugfix for standby task creation#7146

Merged
mjsax merged 1 commit intoapache:2.0from
cadonna:standby_task_creation_fix
Aug 8, 2019
Merged

KAFKA-8602: Backport bugfix for standby task creation#7146
mjsax merged 1 commit intoapache:2.0from
cadonna:standby_task_creation_fix

Conversation

@cadonna
Copy link
Copy Markdown
Member

@cadonna cadonna commented Aug 1, 2019

Backports bugfix in standby task creation from PR #7008.
A separate PR is needed because some tests in the original PR
use topology optimizations and mocks that were introduced afterwards.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

Backports bugfix in standby task creation from PR apache#7008.
A separate PR is needed because some tests in the original PR
use topology optimizations and mocks that were introduced afterwards.
@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 1, 2019

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Aug 1, 2019

retest this please

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Aug 1, 2019

Retest this please

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 2, 2019

Retest this, please

@bbejeck
Copy link
Copy Markdown
Member

bbejeck commented Aug 2, 2019

retest this please

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Aug 4, 2019

Java 10 errors:

kafka.api.SaslGssapiSslEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl
kafka.api.SslEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl

Java8 failed, too. Results are not available any longer.

Retest this please.

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 5, 2019

Retest this, please

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 5, 2019

In Java 10 the following tests failed:

kafka.api.AdminClientIntegrationTest.testConsumeAfterDeleteRecords
kafka.api.SslEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl
kafka.server.LogDirFailureTest.testIOExceptionDuringLogRoll
org.apache.kafka.streams.scala.KStreamTest.join 2 KStreams should join correctly records

In Java 8 the following tests failed:

kafka.api.AdminClientIntegrationTest.testConsumeAfterDeleteRecords
kafka.api.AdminClientIntegrationTest.testDeleteRecordsWithException
kafka.api.SaslPlainSslEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl

Retest this, please

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 6, 2019

In Java 10 the following test failed

kafka.server.LogDirFailureTest.testIOExceptionDuringLogRoll

In Java 8 the following 190 tests failed.

Retest this, please

@mjsax
Copy link
Copy Markdown
Member

mjsax commented Aug 6, 2019

Java 10 failures:

kafka.admin.ResetConsumerGroupOffsetTest.testResetOffsetsToEarliestOnTopicsAndPartitions
kafka.api.PlaintextEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl
kafka.api.SaslOAuthBearerSslEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl

Seems Java10 is just flaky.

Java8 had 169 failures, including

org.apache.kafka.streams.scala.KStreamTest.join 2 KStreams should join correctly records

java.lang.NullPointerException
	at org.apache.kafka.streams.scala.KStreamTest$$anonfun$6.apply$mcV$sp(KStreamTest.scala:151)
	at org.apache.kafka.streams.scala.KStreamTest$$anonfun$6.apply(KStreamTest.scala:137)
	at org.apache.kafka.streams.scala.KStreamTest$$anonfun$6.apply(KStreamTest.scala:137)

Seems this fails regularly? Also reported above. Retesting to verify.

The other failures in Java8 seems env issue with regard to Junit (this may depend which host is executing the run? I think, not all workers have the same setup...)

Retest this please.

@cadonna
Copy link
Copy Markdown
Member Author

cadonna commented Aug 7, 2019

Java 8 passed.

In Java 10 the following tests failed:

kafka.api.AdminClientIntegrationTest.testConsumeAfterDeleteRecords
kafka.api.GroupEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl
kafka.api.SslEndToEndAuthorizationTest.testProduceConsumeTopicAutoCreateTopicCreateAcl

Probably flaky. None of those tests failed in all Java 10 build runs.

@mjsax mjsax merged commit 79eaddd into apache:2.0 Aug 8, 2019
@cadonna cadonna deleted the standby_task_creation_fix branch October 21, 2019 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants